Messages in this thread | | | Date | Wed, 4 Feb 2009 15:52:03 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [-mm patch] Show memcg information during OOM (v3) |
| |
On Wed, 04 Feb 2009 14:48:58 +0800 Li Zefan <lizf@cn.fujitsu.com> wrote:
> >> BTW, I wonder can't we show the path of mount point ? > >> /group_A/01 is /cgroup/group_A/01 and /group_A/ is /cgroup/group_A/ on this system. > >> Very difficult ? > >> > > > > No, it is not very difficult, we just need to append the mount point. > > The reason for not doing it is consistency with output of > > /proc/<pid>/cgroup and other places where cgroup_path prints the path > > relative to the mount point. Since we are talking about memory, the > > administrator should know where it is mounted. Do you strongly feel > > the need to add mount point? My concern is consistency with other > > cgroup output (look at /proc/sched_debug) for example. > > > > Another reason to not do so is, we can mount a specific hierarchy to > multiple mount points. > # mount -t cgroup -o memory /mnt > # mount -t cgroup -o memory /cgroup > # mkdir /mnt/0 > Now, /mnt/0 is the same with /cgroup/0. > Thank you for clarification. Current logic seems right.
Thanks. -Kame
| |