lkml.org 
[lkml]   [2009]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ACPI: add missing KERN_* constants to printks
Date
Frank Seidel wrote:
> +++ b/drivers/acpi/pci_link.c
> @@ -593,7 +593,7 @@ static int acpi_pci_link_allocate(struct
> return -ENODEV;
> } else {
> acpi_irq_penalty[link->irq.active] += PIRQ_PENALTY_PCI_USING;
> - printk(PREFIX "%s [%s] enabled at IRQ %d\n",
> + printk(KERN_WARNING PREFIX "%s [%s] enabled at IRQ %d\n",
> acpi_device_name(link->device),
> acpi_device_bid(link->device), link->irq.active);
> }
> @@ -751,21 +751,21 @@ static int acpi_pci_link_add(struct acpi
> acpi_device_bid(device));
> for (i = 0; i < link->irq.possible_count; i++) {
> if (link->irq.active == link->irq.possible[i]) {
> - printk(" *%d", link->irq.possible[i]);
> + printk(KERN_INFO " *%d", link->irq.possible[i]);
> found = 1;
> } else
> - printk(" %d", link->irq.possible[i]);
> + printk(KERN_INFO " %d", link->irq.possible[i]);
> }
>
> - printk(")");
> + printk(KERN_INFO ")");
>
> if (!found)
> - printk(" *%d", link->irq.active);
> + printk(KERN_INFO " *%d", link->irq.active);
>

This patch looks broken to me, at least for some of your changes.
For example, in the bit quoted above all printks together make up
*one single* message, which means that only the _first_ of the
printks should have the KERN_* prefix. printks that are continuations
should not have the prefix.

Cheers,
FJP


\
 
 \ /
  Last update: 2009-02-04 16:31    [W:0.654 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site