lkml.org 
[lkml]   [2009]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/15] ide: include <asm/ide.h> only when needed
From
On Mon, 2 Feb 2009 19:27:25 +0100, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> > > +#include <asm/ide.h>
> >
> > Did you try checkpatch.pl?
>
> Sure.
>
> This driver uses stuff from <asm-mips/ide.h>.
>
> [ I guess I could put '-mips' there to silence warnings on tx493{8,9}.c,
> however I don't know of the way to get rid of ide-io-std.c's one... ]

BTW, tx4939ide_{in,out}put_data_swap and
tx4939ide_{in,out}put_data_swap do exactly same thing.

If byte-swapped version of ide_{in,out}put_data() were available by
ide core, they can be used instead. The byte-swapped version of
default_tp_ops would much helps such queer big-endian platforms. Is
it worth to bloat ide core? ;-)

---
Atsushi Nemoto


\
 
 \ /
  Last update: 2009-02-04 15:25    [W:0.059 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site