Messages in this thread | | | Date | Wed, 04 Feb 2009 23:20:06 +0900 (JST) | Subject | Re: [PATCH 01/15] ide: include <asm/ide.h> only when needed | From | Atsushi Nemoto <> |
| |
On Mon, 2 Feb 2009 19:27:25 +0100, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > > > +#include <asm/ide.h> > > > > Did you try checkpatch.pl? > > Sure. > > This driver uses stuff from <asm-mips/ide.h>. > > [ I guess I could put '-mips' there to silence warnings on tx493{8,9}.c, > however I don't know of the way to get rid of ide-io-std.c's one... ]
BTW, tx4939ide_{in,out}put_data_swap and tx4939ide_{in,out}put_data_swap do exactly same thing.
If byte-swapped version of ide_{in,out}put_data() were available by ide core, they can be used instead. The byte-swapped version of default_tp_ops would much helps such queer big-endian platforms. Is it worth to bloat ide core? ;-)
--- Atsushi Nemoto
| |