lkml.org 
[lkml]   [2009]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [BUG] Suspend tries to suspend devices already in D3
    Date
    On Wednesday 04 February 2009, Frans Pop wrote:
    > On Wednesday 04 February 2009, Rafael J. Wysocki wrote:
    > > On Tuesday 03 February 2009, Frans Pop wrote:
    > > > On Tuesday 03 February 2009, Frans Pop wrote:
    > > > > Looking at iwl-agn.c the cause could be that iwl_pci_suspend()
    > > > > depends on iwl_mac_stop() to call pci_save_state(). I added some
    > > > > debug statements in iwl_pci_suspend() that showed priv->is_open is
    > > > > false, so iwl_mac_stop does indeed *not* get called when the
    > > > > interface is down.
    > > >
    > > > However, iwl_mac_stop() had been called when I ran ifdown just before
    > > > suspending the system:
    > >
    > > The problem that the warning can be triggered by a device being in a
    > > low power state already before suspend should be fixed by the PCI PM
    > > fixes I've just posted.
    >
    > I'm afraid I still get the warning with your latest patches on top of
    > v2.6.29-rc3-495-gdcf6a79.

    If you're still getting the warning with these patches, then yes, the problem
    appears to be in iwl-agn.c .

    > IIUC the device is not yet in low power state when I suspend, but only
    > disabled. The subject of the mail proved to be incorrect, sorry.
    >
    > Please take a look at the functions from iwl-agn.c mentioned above. I
    > think the problem is there.

    I will.

    Thanks,
    Rafael


    \
     
     \ /
      Last update: 2009-02-04 13:19    [W:0.023 / U:0.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site