lkml.org 
[lkml]   [2009]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 3/4] kthreads: rework kthread_stop()
    Date
    On Wednesday 04 February 2009 15:40:06 Eric W. Biederman wrote:
    > static struct kthread *to_kthread(struct task_struct *tsk)
    > {
    > void *stack = task_stack_page(tsk);
    > return (struct kthread *)(stack + kthread_offset);
    >
    > }
    ...
    > It would remove the test and be simple and obviously correct.

    Clever? Sure. Neat? Yes.

    But you are using a definition of obvious with which I was not previously
    familiar :)

    Rusty.


    \
     
     \ /
      Last update: 2009-02-04 12:07    [W:0.018 / U:59.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site