Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 3/4] kthreads: rework kthread_stop() | Date | Wed, 4 Feb 2009 21:34:31 +1030 |
| |
On Wednesday 04 February 2009 15:40:06 Eric W. Biederman wrote: > static struct kthread *to_kthread(struct task_struct *tsk) > { > void *stack = task_stack_page(tsk); > return (struct kthread *)(stack + kthread_offset); > > } ... > It would remove the test and be simple and obviously correct.
Clever? Sure. Neat? Yes.
But you are using a definition of obvious with which I was not previously familiar :)
Rusty.
| |