lkml.org 
[lkml]   [2009]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: + work_on_cpu-rewrite-it-to-create-a-kernel-thread-on-demand.patch added to -mm tree
    Date
    On Wednesday 04 February 2009 05:55:29 Andrew Morton wrote:
    > On Tue, 3 Feb 2009 17:58:13 +0100
    > Fr__d__ric Weisbecker <fweisbec@gmail.com> wrote:
    >
    > > 2009/2/3 Ingo Molnar <mingo@elte.hu>:
    > > >
    > > > * akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
    > > >
    > > >> ------------------------------------------------------
    > > >> Subject: work_on_cpu(): rewrite it to create a kernel thread on demand
    > > >> From: Andrew Morton <akpm@linux-foundation.org>
    > > >>
    > > >> The various implemetnations and proposed implemetnations of work_on_cpu()
    > > >> are vulnerable to various deadlocks because they all used queues of some
    > > >> form.
    > > >>
    > > >> Unrelated pieces of kernel code thus gained dependencies wherein if one
    > > >> work_on_cpu() caller holds a lock which some other work_on_cpu() callback
    > > >> also takes, the kernel could rarely deadlock.
    > > >>
    > > >> Fix this by creating a short-lived kernel thread for each work_on_cpu()
    > > >> invokation.
    > > >>
    > > >> This is not terribly fast, but the only current caller of work_on_cpu() is
    > > >> pci_call_probe().
    > > >
    > > > hm, it's quite ugly as well
    >
    > No it isn't.
    >
    > It's no less ugly than the current code.
    >
    > It's less buggy than the current code.

    Whatever, I like your version.

    Tho making it a series of 5 and exposing rdmsr_on_cpu/wrmsr_on_cpu for other
    uses would be even better.

    Thanks,
    Rusty.


    \
     
     \ /
      Last update: 2009-02-04 05:01    [W:0.035 / U:33.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site