Messages in this thread | | | Date | Wed, 04 Feb 2009 09:35:32 +0800 | From | Li Zefan <> | Subject | Re: [-mm patch] Show memcg information during OOM (v3) |
| |
>> +void mem_cgroup_print_oom_info(struct mem_cgroup *memcg, struct task_struct *p) >> +{ >> + struct cgroup *task_cgrp; >> + struct cgroup *mem_cgrp; >> + /* >> + * Need a buffer on stack, can't rely on allocations. The code relies > > I think it's in .bss section, but not on stack
> and it's better to explain why > the static buffer is safe in the comment. >
Sorry, I just saw the below comment.
>> + * on the assumption that OOM is serialized for memory controller. >> + * If this assumption is broken, revisit this code. >> + */ >> + static char task_memcg_name[PATH_MAX]; >> + static char memcg_name[PATH_MAX]; >> + int ret; >
| |