Messages in this thread | | | Date | Tue, 3 Feb 2009 17:16:40 -0800 | From | Greg KH <> | Subject | Re: [PATCH 2/2 RESEND] platform: introduce module id table for platform devices |
| |
On Mon, Feb 02, 2009 at 06:11:48PM +0800, Eric Miao wrote: > > > > surely you mean PLATFORM_NAME_SIZE in this struct? > > Indeed, patch updated below (and as attached):
With this patch, I get the following warning: drivers/base/platform.c:598: warning: assignment discards qualifiers from pointer target type
Also, don't put platform_match_id() underneath the comments for platform_match(), that will only confuse the kernel-doc scripts and any developer looking at the code.
Care to fix it up and resend?
thanks,
greg k-h
| |