lkml.org 
[lkml]   [2009]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2 RESEND] platform: introduce module id table for platform devices
On Mon, Feb 02, 2009 at 06:11:48PM +0800, Eric Miao wrote:
> >
> > surely you mean PLATFORM_NAME_SIZE in this struct?
>
> Indeed, patch updated below (and as attached):

With this patch, I get the following warning:
drivers/base/platform.c:598: warning: assignment discards qualifiers from pointer target type

Also, don't put platform_match_id() underneath the comments for
platform_match(), that will only confuse the kernel-doc scripts and any
developer looking at the code.

Care to fix it up and resend?

thanks,

greg k-h


\
 
 \ /
  Last update: 2009-02-04 02:31    [W:0.495 / U:2.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site