Messages in this thread | | | Date | Tue, 3 Feb 2009 15:52:08 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH B 02/10] OMAP2/3 clockdomains: combine pwrdm, pwrdm_name into union in struct clockdomain |
| |
On Tue, Feb 03, 2009 at 02:20:44AM -0700, Paul Walmsley wrote: > Hello Russell, > > On Sat, 31 Jan 2009, Russell King - ARM Linux wrote: > > > On Tue, Jan 27, 2009 at 07:44:11PM -0700, Paul Walmsley wrote: > > > struct clockdomain contains a struct powerdomain *pwrdm and const char > > > *pwrdm_name. The pwrdm_name is only used at initialization to look up > > > the appropriate pwrdm pointer. Combining these into a union saves > > > about 100 bytes on 3430SDP. This patch should not cause any change in > > > kernel function. > > > > For the same reasons as B1, this would seem to be unsafe. > > Fixed; updated patch attached below.
Better. Can I have it in email format so git-am can handle it please?
| |