lkml.org 
[lkml]   [2009]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH 5/8] add f_op for checkpointability
From
Date
On Sat, 2009-02-28 at 15:53 -0500, Christoph Hellwig wrote:
> On Fri, Feb 27, 2009 at 12:34:31PM -0800, Dave Hansen wrote:
> > We have set up sane defaults for how filesystems should
> > be checkpointed. However, as usual in the VFS, there
> > are specialized places that will always need an ability
> > to override these defaults.
> >
> > This adds a new 'file_operations' function for
> > checkpointing a file. I did this under the assumption
> > that we should have a dirt-simple way to make something
> > (un)checkpointable that fits in with current code.
> >
> > As you can see in the /dev/null patch in a second, all
> > that we have to do to make something like /dev/null
> > supported is add a single "generic" f_op entry.
>
> Please don't do the fallback to allow checkpointing without file
> operations. We've never had luck with these fallbacks, and I'm
> in the process of getting of the last default file operation (llseek,
> which has a very bad default) currently.

You'll probably believe me when I tell you that I was looking at how
lseek was done when I did this. :)

Doing this will make for a much, much bigger patch, but I do understand
why you're asking for it to be done this way, so I'll give it a shot for
the next round.

> Incidentally that should also allow you to get rid of the per-fs flag
> by just checking for the presence of the operation to check if
> checkpointing is allowed.

Yup, I completely agree. The flag was basically an indicator when it
was OK to do the fallback.

> Also the double-use of the op seem not very nice to me. Is there any
> real life use case were you would have the operation on a file but
> sometimes not allow checkpoiting?

No, I don't have any good concrete ones. The first thing that comes to
mind is something like a pipe. We can checkpoint when there's no data,
but must refuse when there's data in the pipe. In practice, pipes are
fixable, but it is the kind of situation where I expected it to get
used.

Thanks, Christoph.

-- Dave



\
 
 \ /
  Last update: 2009-02-28 22:39    [W:0.087 / U:3.600 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site