Messages in this thread | | | Date | Sat, 28 Feb 2009 17:52:20 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] checkpatch: Warn on empty commit log bodies |
| |
On Sat, Feb 28, 2009 at 06:33:23PM +0100, Stefan Richter wrote:
> This really surprises me. ^Subject: .+$ is the title of the log and > thereby its first part. Also, I don't see a connection to git. I > manage patches with quilt and never loose patch titles. I still think > you should count ^Subject: .+$ too if you want to check for presence of > a changelog.
I believe the issue is the UI of a MUA - the subject line of a mail is normally presented separately to the body and isn't always as immediately prominent as the body so it's harder work to look at it. This is sensible for e-mail since the general style is that the subject line shouldn't be required in order to comprehend what the message is about but that's exactly what's happening when a one line changelog is e-mailed.
The connection with git is that it doesn't really draw a similar distinction so the issue isn't as immediately obvious when you're working within it.
| |