lkml.org 
[lkml]   [2009]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] checkpatch: Warn on empty commit log bodies
Mark Brown wrote:
> On Sat, Feb 28, 2009 at 02:58:14PM +0100, Stefan Richter wrote:
>
>> This gives false positives for patches like this:
>
>> From: [...]
>> Subject: this single line fully explains the whole patch
>
>> Signed-off-by: [...]
>
> That's not a false postive, that's exactly the case it's intended to
> catch.

It *is* a false positive if a single-line changelog is entirely
sufficient. (There are many patches whose changelogs can and should be
a single line, plus sign-offs.)

You could as well

if few_changelog_lines
warn "You have written a short changelog."
warn "Don't you want to write some more?"
warn "(PS: I don't care what you write in particular"
warn "as long as you just add more lines.)"

if many_changelog_lines
warn "You have written a long changelog."
warn "Can't you express yourselves more concisely?"
warn "(PS: I don't care what you'll omit in particular"
warn "as long as you get the line count down.)"

> People like Andrew Morton complain because there's no text in
> the actual body of the email (as well as because some of the patches
> that do this could probably use a bit more explanation).

Well, I haven't closely watched akpm's complaints, but I'm sure he
doesn't complain about too few lines changelog, he complains about
insufficient information in the changelog.

Your checkpatch modification does not check for insufficient information
in the changelog. It only checks line count.
--
Stefan Richter
-=====-==--= --=- ===--
http://arcgraph.de/sr/

\
 
 \ /
  Last update: 2009-02-28 17:17    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site