lkml.org 
[lkml]   [2009]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/2] mfd: twl4030: add twl4030-pwrbutton as our child
    Date
    On Friday 27 February 2009, Andrew Morton wrote:
    > > >
    > > > What has gone wrong here?
    > >
    > > Not much I can see.  It's registering a platform_device,
    > > but only if it could be used on this system.
    >
    > Again, that all gets fixed if this is done the right way around.  Run
    > your probe function.  If the hardware is there, register with the core
    > and all the nodes appear.  If the hardware is not present: bale.

    Right. If there's no button hooked up to its "power button"
    signal, don't register that "twl4030-pwrbutton" node.


    > The design of the whole subsystem appears to be upside down :(

    You seem to be missing something. Is it only the lack of that
    tweak Felipe sent?

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-02-28 00:23    [W:0.025 / U:0.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site