lkml.org 
[lkml]   [2009]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] modpost: Check the section flags, not name, to catch missing "ax"/"aw"
Anders Kaseorg wrote:
> On Tue, 24 Feb 2009, H. Peter Anvin wrote:
>> This is a pretty critical set of warnings, that often represent real
>> bugs. I don't think it's acceptable to lose them. However, you already
>> have (prior in the sequence) changed those section names to not conflict
>> with the automatically generated ones, so it seems to me that this
>> should be fixable without too much pain.
>
> Actually, the problem arises from a conflict between two classes of
> automatically generated section names, one from ld, and one from gcc.
> Instead of basing the warning on section names (the existing heuristic
> also fails to warn on some cases where it should, as it turns out), what
> do you think about this patch? I've tested that it still triggers the
> warning when an "ax" or "aw" is incorrectly removed, and it should handle
> even more cases than before.
>

Seems reasonable to me.

-hpa


--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2009-02-27 13:39    [W:0.050 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site