lkml.org 
[lkml]   [2009]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUGFIX] dm-crypt: Fix a bug of async cryption complete function
On Fri, Feb 27, 2009 at 12:52:05PM +0100, Milan Broz wrote:
> Herbert Xu wrote:
> > On Fri, Feb 27, 2009 at 04:56:11PM +0800, Huang Ying wrote:
> >> @@ -830,7 +838,7 @@ static void kcryptd_async_done(struct cr
> >> return;
> >> }
> >>
> >> - mempool_free(ablkcipher_request_cast(async_req), cc->req_pool);
> >> + mempool_free(dmreq->req, cc->req_pool);
> >
> > Why do we need all this complexity? Can't just fix it by using
> > cc->req?
>
> No. There can be parallel req allocated, also cc->req can be NULL.
> (seems that these structs are overcomplicated already:-)

Fair enough. However we still shouldn't need to have dmreq->req
since

dmreq->req == (char *)dmreq - sizeof(dmreq->req)

In fact just pass the request itself as data and derive dmreq
from that.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


\
 
 \ /
  Last update: 2009-02-27 12:59    [W:0.504 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site