lkml.org 
[lkml]   [2009]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Staging/p9auth] Feb 26 Next: build failure
On Thu, Feb 26, 2009 at 08:59:32AM -0800, Randy Dunlap wrote:
> Greg KH wrote:
> > On Thu, Feb 26, 2009 at 04:40:10PM +0530, Sachin P. Sant wrote:
> >> Feb 26 Next tree randconfig build fails with
> >>
> >> drivers/staging/p9auth/p9auth.c: In function cap_write:
> >> drivers/staging/p9auth/p9auth.c:249: error: implicit declaration of
> >> function current_uid
> >> drivers/staging/p9auth/p9auth.c:261: error: implicit declaration of
> >> function prepare_creds
> >> drivers/staging/p9auth/p9auth.c:261: warning: assignment makes pointer from
> >> integer without a cast
> >> drivers/staging/p9auth/p9auth.c:266: error: dereferencing pointer to
> >> incomplete type
> >> drivers/staging/p9auth/p9auth.c:267: error: dereferencing pointer to
> >> incomplete type
> >> drivers/staging/p9auth/p9auth.c:268: error: implicit declaration of
> >> function commit_creds
> >> make[3]: *** [drivers/staging/p9auth/p9auth.o] Error 1
> >
> > Wierd, I thought cred.h would be pulled in with the current include
> > files.
>
> Even if it were, that's not what we want. We want explicit #includes
> for macros or structs etc. that are used in a source file.
>
> > With this .config, if you add:
> > #include <linux/cred.h>
> > to drivers/staging/p9auth/p9auth.c does it solve the build error?
> >
> > I'll go add it just to be safe :)
>
> It needs both cred.h and sched.h in my testing.

Now done, it will show up in tomorrow's -next tree.

thanks,

greg k-h


\
 
 \ /
  Last update: 2009-02-26 18:49    [W:0.087 / U:1.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site