lkml.org 
[lkml]   [2009]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] [-mm] epoll: clean up ep_modify
On Tue, 24 Feb 2009, Tony Battersby wrote:

> ep_modify() doesn't need to set event.data from within the ep->lock
> spinlock as the comment suggests. The only place event.data is used
> is ep_send_events_proc(), and this is protected by ep->mtx instead
> of ep->lock. Also update the comment for mutex_lock() at the top
> of ep_scan_ready_list(), which mentions epoll_ctl(EPOLL_CTL_DEL)
> but not epoll_ctl(EPOLL_CTL_MOD).
>
> ep_modify() can also use spin_lock_irq() instead of
> spin_lock_irqsave().

Pre-mtx stuff.

Acked-by: Davide Libenzi <davidel@xmailserver.org>


- Davide




\
 
 \ /
  Last update: 2009-02-26 17:33    [W:0.154 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site