lkml.org 
[lkml]   [2009]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/5] [RFC] copy_strtok_from_user

On Thu, 26 Feb 2009, Steven Rostedt wrote:

>
> On Thu, 26 Feb 2009, Ingo Molnar wrote:
> > >
> > > yes. Note that strsep() is the preferred API. (in fact it's
> > > the only such string API that is in the kernel)
> >
> > btw., for larger strings we cannot really copy into the kernel i
> > suspect. We'd have to kmalloc() and that adds overhead, etc.
> >
> > Nevertheless, copy_strsep_from_user() would be the symmetric API
> > here.
>
> OK, I'll rebase again calling it copy_strsep_from_user. And I'll change
> the implementation to use copy_from_user/strsep

I need to have my first cup of coffee _before_ replying :-p

My first understanding of strsep was correct. strsep stops at the first
delimiter. It may be time to add strtok_r into the kernel.

-- Steve



\
 
 \ /
  Last update: 2009-02-26 15:07    [W:0.052 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site