Messages in this thread | | | From | "Thomas Jourdan" <> | Subject | RE: [BUG] dmi_scan_machine uses uninitialized address on x86 / EFI | Date | Wed, 25 Feb 2009 13:28:04 +0100 |
| |
Hi guys
The bug is not critical. Vanilla kernel works fine without the patch, except for the DMI sysfs stuffs.
Without the patch, if CONFIG_DMI is enabled, I got the "DMI not present or invalid." error message on boot. Then later, if CONFIG_DMIID is enabled, DMI system identification informations won't be exported via sysfs to userspace. The /sys/class/dmi/id entry is not present.
Regards, Thomas
-----Message d'origine----- De : H. Peter Anvin [mailto:hpa@zytor.com] Envoyé : mar. 24 février 2009 22:12 À : Thomas Jourdan Cc : linux-kernel@vger.kernel.org; Huang Ying; Peter Jones; Yinghai Lu Objet : Re: [BUG] dmi_scan_machine uses uninitialized address on x86 / EFI
Thomas Jourdan wrote: > > On x86/EFI platforms, if efi_enabled is true, the dmi_scan_machine function > fails, even if valid DMI table is present. In the setup_arch function, > efi_init is called after dmi_scan_machine. But this is efi_init which will > initialize the smbios address, needed by dmi_scan_machine. > > This leads to dmi_scan_machine ioremapping physical address 0, instead of > the address provided by the EFI system table. The following patch fixes the > problem. >
Hi Thomas,
What is the concrete manifestation of the bug (i.e. how critical is it?) We are late in the 2.6.29-rc cycle, and this patch seems to have some risk associated with it.
Huang, Peter, Yinghai: any opinions?
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
__________ Information NOD32 3887 (20090224) __________
Ce message a ete verifie par NOD32 Antivirus System. http://www.nod32.com
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |