Messages in this thread | | | Date | Wed, 25 Feb 2009 16:31:26 -0500 | From | Rik van Riel <> | Subject | Re: [patch] mm: don't free swap slots on page deactivation |
| |
Johannes Weiner wrote: > The pagevec_swap_free() at the end of shrink_active_list() was > introduced in 68a22394 "vmscan: free swap space on swap-in/activation" > when shrink_active_list() was still rotating referenced active pages. > > In 7e9cd48 "vmscan: fix pagecache reclaim referenced bit check" this > was changed, the rotating removed but the pagevec_swap_free() after > the rotation loop was forgotten, applying now to the pagevec of the > deactivation loop instead. > > Now swap space is freed for deactivated pages. And only for those > that happen to be on the pagevec after the deactivation loop. > > Complete 7e9cd48 and remove the rest of the swap freeing. > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> > Cc: Rik van Riel <riel@redhat.com>
Acked-by: Rik van Riel <riel@redhat.com>
-- All rights reversed.
| |