lkml.org 
[lkml]   [2009]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/7] sound/oss: fix sparse warnings: different signedness
    Date
    Impact: Change signature of 'set_volume_stereo' and 'set_volume_mono'.

    Fix this sparse warnings:
    sound/oss/pss.c:545:42: warning: incorrect type in argument 2 (different signedness)
    sound/oss/pss.c:546:42: warning: incorrect type in argument 3 (different signedness)
    sound/oss/pss.c:554:59: warning: incorrect type in argument 2 (different signedness)
    sound/oss/pss.c:560:59: warning: incorrect type in argument 2 (different signedness)
    sound/oss/pss.c:566:59: warning: incorrect type in argument 2 (different signedness)

    Signed-off-by: Hannes Eder <hannes@hanneseder.net>
    ---
    sound/oss/pss.c | 12 ++++++------
    1 files changed, 6 insertions(+), 6 deletions(-)

    diff --git a/sound/oss/pss.c b/sound/oss/pss.c
    index 902b39e..83f5ee2 100644
    --- a/sound/oss/pss.c
    +++ b/sound/oss/pss.c
    @@ -457,10 +457,9 @@ static void pss_mixer_reset(pss_confdata *devc)
    }
    }

    -static int set_volume_mono(unsigned __user *p, int *aleft)
    +static int set_volume_mono(unsigned __user *p, unsigned int *aleft)
    {
    - int left;
    - unsigned volume;
    + unsigned int left, volume;
    if (get_user(volume, p))
    return -EFAULT;

    @@ -471,10 +470,11 @@ static int set_volume_mono(unsigned __user *p, int *aleft)
    return 0;
    }

    -static int set_volume_stereo(unsigned __user *p, int *aleft, int *aright)
    +static int set_volume_stereo(unsigned __user *p,
    + unsigned int *aleft,
    + unsigned int *aright)
    {
    - int left, right;
    - unsigned volume;
    + unsigned int left, right, volume;
    if (get_user(volume, p))
    return -EFAULT;



    \
     
     \ /
      Last update: 2009-02-25 22:33    [W:0.026 / U:0.096 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site