Messages in this thread | | | From | "Luck, Tony" <> | Date | Wed, 25 Feb 2009 10:25:04 -0800 | Subject | RE: smp.c && barriers (Was: [PATCH 1/4] generic-smp: remove single ipi fallback for smp_call_function_many()) |
| |
> Just if I may add something -- I would probably slightly prefer if > you explicitly used an sfence or other serializing instruction rather > than smp_mb(). Maybe call it wrmsr_fence() or something. Apart from > being self documenting, and less confusing (wrmsr is not part of > normal ordering), I assume you technically also need it on UP > systems?
Maybe I lost track of this thread ... but isn't this code for the "send ipi" path? On a UP system do we use IPI to interrupt ourself? Even if we did, presumably we can't get inconsistencies if there is only one cpu.
-Tony
| |