Messages in this thread | | | Date | Wed, 25 Feb 2009 11:13:35 -0500 | From | Mathieu Desnoyers <> | Subject | Re: [PATCH 1/4] tracing: add DEFINE_TRACE_FMT to tracepoint.h |
| |
* Steven Rostedt (rostedt@goodmis.org) wrote: > From: Steven Rostedt <srostedt@redhat.com> > > This patch creates a DEFINE_TRACE_FMT to map to DECLARE_TRACE. > This allows for the developers to place format strings and > args in with their tracepoint declaration. A tracer may now > override the DEFINE_TRACE_FMT macro and use it to record > a default format. >
Hi Steven,
How comes does a DEFINE_* maps to a DECLARE_* ?
Usually, DEFINE_* are meant to be put in .c files. DECLARE_* are in headers. I don't see how the mapping you propose here can be semantically correct ?
Mathieu
> Signed-off-by: Steven Rostedt <srostedt@redhat.com> > --- > include/linux/tracepoint.h | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h > index 7570054..34ae464 100644 > --- a/include/linux/tracepoint.h > +++ b/include/linux/tracepoint.h > @@ -153,4 +153,7 @@ static inline void tracepoint_synchronize_unregister(void) > synchronize_sched(); > } > > +#define DEFINE_TRACE_FMT(name, proto, args, fmt) \ > + DECLARE_TRACE(name, TPPROTO(proto), TPARGS(args)) > + > #endif > -- > 1.5.6.5 > > -- >
-- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
| |