Messages in this thread | | | Date | Wed, 25 Feb 2009 15:54:32 +0100 | From | Frank Seidel <> | Subject | Re: [PATCH][trivial] crypto: tcrypt - reduce stack size |
| |
Geert Uytterhoeven wrote: > On Wed, 25 Feb 2009, Frank Seidel wrote: > Wel... > > Using kmalloc() increases code size, makes the code more complex, and increases > the risk of introducing a memory leak now or later.
Ok, admitted.
>> I just stumbled over tcrypt on the make checkstack output and as also >> the kerneljanitors todo advises to reduce this footprint where possible >> i just wanted to help out here. > > Reducing stack usage is fine. However, for a loadable test module without > concurrency issues it's far easier to do that by just making the data static.
Is PATCHv3 then ok for you?
Thanks, Frank
| |