Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 14/15] bitops: Change the bitmap index from int to unsigned long [frv] | Date | Wed, 25 Feb 2009 12:37:10 +0000 |
| |
Justin Chen <jchen@hpdst41.cup.hp.com> wrote:
> Change the index to unsigned long in all bitops for [frv] > > Signed-off-by: Justin Chen <justin.chen@hp.com> > Reviewed-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Mostly okay, apart from:
> -static inline int __constant_test_bit(int nr, const volatile void * addr) > +static inline int > +__constant_test_bit(unsigned long nr, const volatile void *addr)
Please move the return type onto the next line also. Other than that:
Acked-by: David Howells <dhowells@redhat.com>
| |