lkml.org 
[lkml]   [2009]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:core/percpu] bootmem: clean up arch-specific bootmem wrapping
Hello,

Johannes Weiner wrote:
> No, when the patch was submitted for review, I pointed out the change
> in semantics and gathered from Tejun's reaction that this wasn't done
> intentionally. So the problem is the change itself, not the missing
> declaration.

Yeah, I should have regenerated the tree. Sorry about that.

>>From the original mail:
>
> Johannes Weiner wrote:
> > This won't suffice as reserve_bootmem() doesn't use
> > alloc_bootmem_core(), so now you effectively removed the
> > node-0 restriction for reserve_bootmem() on this
> > configuration.
>
> Ah... right. :-(
>
> I just wrote again because I didn't understand why Tejun acknowledged
> the error in the patch and then it went into -tip anyway.
>
> The other part of my email was just suggestions for a cleanup, I
> wasn't referring to that when I said 'broken' - sorry if that is how
> it came over.

It seems that the wrapping thing was broken both before and after the
patch and can lead to panic on free path. I'll soon post a patch to
fix it.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-02-25 03:31    [W:0.106 / U:0.024 seconds]
©2003-2011 Jasper Spaans. Advertise on this site