lkml.org 
[lkml]   [2009]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 2/2] slub: add min_partial sysfs tunable
From
Date
Hi David,

On Sun, 2009-02-22 at 17:40 -0800, David Rientjes wrote:
> Now that a cache's min_partial has been moved to struct kmem_cache, it's
> possible to easily tune it from userspace by adding a sysfs attribute.
>
> It may not be desirable to keep a large number of partial slabs around if
> a cache is used infrequently and memory, especially when constrained by a
> cgroup, is scarce. It's better to allow userspace to set the minimum
> policy per cache instead of relying explicitly on kmem_cache_shrink().

The patches look good but the description is bit lacking. Does this
actually fix up something? Why don't we fix the limit calculations
instead?

I'm a sucker for numbers so I'm easily fooled into merging patches with
statements of the form "this shaves off N bytes/kb/mb on XYZ systems".

Pekka



\
 
 \ /
  Last update: 2009-02-23 09:21    [W:0.095 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site