Messages in this thread | | | Date | Mon, 23 Feb 2009 17:42:28 +0100 | Subject | Re: [RFC PATCH 0/6] module, kbuild: Faster boot with custom kernel. | From | Kay Sievers <> |
| |
On Fri, Feb 20, 2009 at 12:32, Rusty Russell <rusty@rustcorp.com.au> wrote: > On Friday 20 February 2009 11:28:55 Rusty Russell wrote: >> + /* Unlink carefully: kallsyms could be walking list. */ >> + __list_del(&mod->list); >> + synchronize_sched(); > > That should be list_del_rcu() of course.
Rusty, are you taking care, that this patch gets merged somewhere, and shows up in -next?
I still get a ~10% improvement without the mutex, and traces show some parallelism from different modprobe processes. Any idea how to safely minimize the time we need to hold it?
Thanks, Kay
| |