Messages in this thread | | | Date | Mon, 23 Feb 2009 11:20:34 -0500 (EST) | From | Christoph Lameter <> | Subject | Re: [patch 1/2] slub: move min_partial to struct kmem_cach |
| |
On Mon, 23 Feb 2009, David Rientjes wrote:
> > Move the ilog2 use into calculate_min_partial()? Otherweise > > calculate_min_partial is merely enforcing limits and not doing any > > calculations. > > > > The second patch in this series as a /sys/kernel/slab/cache/min_partial > tunable that uses calculate_min_partial() to enforce a sane range, so > while it may not actually be doing any calculations, the ilog2() is > appropriately placed in kmem_cache_open(). We don't want to be taking the > log of the user's min_partial value.
Then Rename the function to set_min_partial()?
| |