lkml.org 
[lkml]   [2009]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] init/main.c: fix sparse warnings: context imbalance
Stefan Richter wrote:
> Hannes Eder wrote:
>> On Sun, Feb 22, 2009 at 12:30 PM, Stefan Richter
>> <stefanr@s5r6.in-berlin.de> wrote:
>>> It is not a fix, it's merely an annotation.
>> This patch 'better word for fix's a warning reported by sparse. What
>> better wording would you suggest?
>
> "annotate init_post() as releasing the BKL" or whatever in the title,
> furthermore "Removes the following sparse warnings: ..." in the changelog.

PS: In some sense it is indeed a "fix" for the high-level problem that
sparse can't guess whether the context imbalance is correct or not. The
original warning from sparse was correct in itself. Your annotation
enables sparse to warn if problems outside the scope of the single
function occur (I guess). So it's more a maintainabiliy improvement
than a fix.
--
Stefan Richter
-=====-==--= --=- =-==-
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2009-02-22 13:49    [W:0.047 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site