lkml.org 
[lkml]   [2009]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectSyscall wrappers breaks things.
In commit ee6a093222549ac0c72cfd296c69fa5e7d6daa34 the syscall wrappers 
infrastructure was introduced.

A typical definition is something like this (from Ralf's patch):

SYSCALL_DEFINE6(32_ipc, u32, call, long, first, long, second, long, third,
unsigned long, ptr, unsigned long, fifth)
{
.
.
.

This creates a symbol sys_32_ipc. The old name of the symbol is
sys32_ipc (note the change in the number of '_').

For the mips64 kernel the syscall table for o32 ABI executable contains:

.
.
.
PTR sys32_ipc
.
.
.

This is now linked to the sys32_ipc function in kernel/sys_ni.c which
kindly returns ENOSYS.

The long and short of the problem is that the is now a kernel wide
mismatch in function names between the names created by SYSCALL_DEFINE*,
the syscall tables and kernel/sys_ni.c.

I am not sure what the best solution is, but something should probably
be done to un-break things.

Thanks,
David Daney


\
 
 \ /
  Last update: 2009-02-20 19:53    [W:0.047 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site