lkml.org 
[lkml]   [2009]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] block bits for 2.6.29-rc5
On Thu, Feb 19 2009, Andrew Morton wrote:
> On Wed, 18 Feb 2009 15:41:06 +0100
> Jens Axboe <jens.axboe@oracle.com> wrote:
>
> > @@ -3404,6 +3601,24 @@ static int __devinit cciss_init_one(struct pci_dev *pdev,
> > int dac, return_code;
> > InquiryData_struct *inq_buff = NULL;
> >
> > + if (reset_devices) {
> > + /* Reset the controller with a PCI power-cycle */
> > + if (cciss_hard_reset_controller(pdev) || cciss_reset_msi(pdev))
> > + return -ENODEV;
> > +
> > + /* Some devices (notably the HP Smart Array 5i Controller)
> > + need a little pause here */
> > + schedule_timeout_uninterruptible(30*HZ);
>
> little!

That does qualify as the understatement of the day :-)

> Perhaps we should do a printk("no, your machine is not dead") here.

Perhaps we should shrink it to something a little more tolerable and put
it in the noop loop instead. 30 seconds is insane...

--
Jens Axboe



\
 
 \ /
  Last update: 2009-02-20 17:45    [W:1.047 / U:0.324 seconds]
©2003-2011 Jasper Spaans. Advertise on this site