Messages in this thread | | | Date | Mon, 2 Feb 2009 14:41:31 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 3/3] pcf50633_charger: Enable periodic charging restart |
| |
On Tue, 27 Jan 2009 19:23:12 +0530 Balaji Rao <balajirrao@openmoko.org> wrote:
> @@ -157,6 +213,7 @@ pcf50633_mbc_irq_handler(int irq, void *data) > mbc->usb_online = 0; > mbc->usb_active = 0; > pcf50633_mbc_usb_curlim_set(mbc->pcf, 0); > + cancel_delayed_work_sync(&mbc->charging_restart_work); > }
eek, can't call cancel_delayed_work_sync() from an interrupt handler! If the work was actually running on this CPU or on a different one, cancel_delayed_work_sync() will need to wait for it to complete. The kernel will explode in many tinkly little pieces.
| |