lkml.org 
[lkml]   [2009]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] pcf50633_charger: Enable periodic charging restart
On Tue, 27 Jan 2009 19:23:12 +0530
Balaji Rao <balajirrao@openmoko.org> wrote:

> @@ -157,6 +213,7 @@ pcf50633_mbc_irq_handler(int irq, void *data)
> mbc->usb_online = 0;
> mbc->usb_active = 0;
> pcf50633_mbc_usb_curlim_set(mbc->pcf, 0);
> + cancel_delayed_work_sync(&mbc->charging_restart_work);
> }

eek, can't call cancel_delayed_work_sync() from an interrupt handler!
If the work was actually running on this CPU or on a different one,
cancel_delayed_work_sync() will need to wait for it to complete. The
kernel will explode in many tinkly little pieces.



\
 
 \ /
  Last update: 2009-02-02 23:49    [W:0.051 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site