Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH -mm 2/2] ptrace_untrace: fix the SIGNAL_STOP_STOPPED check | Date | Thu, 19 Feb 2009 19:49:28 -0800 (PST) |
| |
> This bug is ancient too. ptrace_untrace() must not resume the task > if the group stop in progress, we should set TASK_STOPPED instead.
Right, the change looks correct.
> Unfortunately, we still have problems here: > > - if the process/thread was traced, SIGNAL_STOP_STOPPED > does not necessary means this thread group is stopped. > > - ptrace breaks the bookkeeping of ->group_stop_count.
Neither of these should be true today as I understand the code. So if you have reason to think these, I must be missing something that is likely to be relevant to reviewing this change.
Thanks, Roland
| |