Messages in this thread | | | From | Thomas Backlund <> | Subject | Re: [patch 03/36] Fix Intel IOMMU write-buffer flushing | Date | Fri, 20 Feb 2009 01:59:48 +0200 |
| |
Thomas Backlund skrev: > This patch is broken compared to what's in: > http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ca77fde8e62cecb2c0769052228d15b901367af8 > > > attached patch fixes it >
As no-one responded yet...
I forgot to tell how to reproduce it:
on x86_64:
make defconfig make
and you will end up with: [thomas@tmb linux-2.6.27.19-rc1]$ LC_ALL=C make CHK include/linux/version.h CHK include/linux/utsrelease.h CALL scripts/checksyscalls.sh CHK include/linux/compile.h CC drivers/pci/intel-iommu.o drivers/pci/intel-iommu.c: In function 'iommu_flush_write_buffer': drivers/pci/intel-iommu.c:530: error: 'rwbf_quirk' undeclared (first use in this function) drivers/pci/intel-iommu.c:530: error: (Each undeclared identifier is reported only once drivers/pci/intel-iommu.c:530: error: for each function it appears in.) make[2]: *** [drivers/pci/intel-iommu.o] Error 1 make[1]: *** [drivers/pci] Error 2 make: *** [drivers] Error 2 [thomas@tmb linux-2.6.27.19-rc1]$
This happends because 'rwbf_quirk' is declared after it's first use.
The upstream git has 'rwbf_quirk' declared before any use of it.
That's what my patch fixes, by simply moving
static int rwbf_quirk = 0;
to the beginning of the file...
Hopefully this helps. -- Thomas
| |