lkml.org 
[lkml]   [2009]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 01/10] vmalloc: call flush_cache_vunmap() from unmap_kernel_range()
Date
On Wednesday 18 February 2009 23:04:27 Tejun Heo wrote:
> Impact: proper vcache flush on unmap_kernel_range()
>
> flush_cache_vunmap() should be called before pages are unmapped. Add
> a call to it in unmap_kernel_range().
>
> Signed-off-by: Tejun Heo <tj@kernel.org>

Shouldn't this go as a fix to mainline and even .stable?

Otherwise:
Acked-by: Nick Piggin <npiggin@suse.de>

> ---
> mm/vmalloc.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 75f49d3..c37924a 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1012,6 +1012,8 @@ void __init vmalloc_init(void)
> void unmap_kernel_range(unsigned long addr, unsigned long size)
> {
> unsigned long end = addr + size;
> +
> + flush_cache_vunmap(addr, end);
> vunmap_page_range(addr, end);
> flush_tlb_kernel_range(addr, end);
> }




\
 
 \ /
  Last update: 2009-02-19 13:09    [from the cache]
©2003-2011 Jasper Spaans