lkml.org 
[lkml]   [2009]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 05/39] sata_nv: give up hardreset on nf2
    2.6.28-stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Tejun Heo <tj@kernel.org>

    commit 7dac745b8e367c99175b8f0d014d996f0e5ed9e5 upstream.

    Kernel bz#12176 reports that nf2 hardreset simply doesn't work. Give
    up. Argh...

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Cc: Robert Hancock <hancockr@shaw.ca>
    Reported-by: Saro <saro_v@hotmail.it>
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/ata/sata_nv.c | 14 ++++++++------
    1 file changed, 8 insertions(+), 6 deletions(-)
    --- a/drivers/ata/sata_nv.c
    +++ b/drivers/ata/sata_nv.c
    @@ -421,19 +421,21 @@ static struct ata_port_operations nv_gen
    .hardreset = ATA_OP_NULL,
    };

    -/* OSDL bz3352 reports that nf2/3 controllers can't determine device
    - * signature reliably. Also, the following thread reports detection
    - * failure on cold boot with the standard debouncing timing.
    +/* nf2 is ripe with hardreset related problems.
    + *
    + * kernel bz#3352 reports nf2/3 controllers can't determine device
    + * signature reliably. The following thread reports detection failure
    + * on cold boot with the standard debouncing timing.
    *
    * http://thread.gmane.org/gmane.linux.ide/34098
    *
    - * Debounce with hotplug timing and request follow-up SRST.
    + * And bz#12176 reports that hardreset simply doesn't work on nf2.
    + * Give up on it and just don't do hardreset.
    */
    static struct ata_port_operations nv_nf2_ops = {
    - .inherits = &nv_common_ops,
    + .inherits = &nv_generic_ops,
    .freeze = nv_nf2_freeze,
    .thaw = nv_nf2_thaw,
    - .hardreset = nv_noclassify_hardreset,
    };

    /* For initial probing after boot and hot plugging, hardreset mostly


    \
     
     \ /
      Last update: 2009-02-18 22:41    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site