Messages in this thread | | | From | Paul Moore <> | Subject | Re: [PATCH] SMACK netfilter smacklabel socket match | Date | Wed, 18 Feb 2009 14:18:35 -0500 |
| |
On Wednesday 18 February 2009 01:29:11 pm etienne wrote: > OK, I'm about to send a new patch; but while testing my patches and reading > code, I noticed another bug : > > In smackfs.c:smk_write_netlbladdr > the netmask mask.s_addr is not handled correctly, the netmask should be : > 1- computed in u32 > 2- converted to be32 !! > with current code, a "pseudo u32 mask" is applied to a be32 ipaddr; it > occurs to works for "common netmasks" (multiple of 8), not for > "intermediate" mask (/15, /25)
Heh, back when Casey was first drafting this code I mentioned the same issue regarding byte ordering but Casey assured me that everything was correct. I didn't have a Smack test system at the time so I couldn't verify the behavior. I'm glad you had a chance to test it, needless to say you should fix that when you submit your patch.
-- paul moore linux @ hp
| |