lkml.org 
[lkml]   [2009]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] SMACK netfilter smacklabel socket match
    etienne wrote:
    > hello,
    >
    > Paul Moore wrote:
    > ..
    >
    >> Well, since you have some time and willingness to do things "the right way" I
    >> would recommend dropping these patches (which are really just band-aids) and
    >> working on the right solution to stored the addresses/masks in a sorted list
    >> with the mask already applied.
    >>
    >>
    > OK, I'm about to send a new patch; but while testing my patches and reading code, I noticed another bug :
    >
    > In smackfs.c:smk_write_netlbladdr
    > the netmask mask.s_addr is not handled correctly, the netmask should be :
    > 1- computed in u32
    > 2- converted to be32 !!
    > with current code, a "pseudo u32 mask" is applied to a be32 ipaddr; it occurs to works for "common netmasks" (multiple of 8), not for "intermediate" mask (/15, /25)
    >

    Well, that's embarrassing. I am really looking forward to your
    fixes!





    \
     
     \ /
      Last update: 2009-02-18 20:09    [W:0.021 / U:214.652 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site