lkml.org 
[lkml]   [2009]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.6.29-rc4 regression (was: Re: 2.6.28-rc9: oprofile regression)
> still, I can not reproduce this with my tests with v2.6.29-rc4. The
> regression on the systems I have runs fine on rc4. On the system you
> have, is commit b99170288421c79f0c2efa8b33e26e65f4bb7fb8 the first bad
> one? If so, I will split the patch into smaller pieces to find the
> change that introduces the bug.

i got revision df13b31c286b3e91c556167954eda088d90a4295 working, by not
resetting the counter width:

diff --git a/arch/x86/oprofile/op_model_ppro.c b/arch/x86/oprofile/op_model_ppro.c
index 12e207a..f0e019d 100644
--- a/arch/x86/oprofile/op_model_ppro.c
+++ b/arch/x86/oprofile/op_model_ppro.c
@@ -76,12 +76,14 @@ static void ppro_setup_ctrs(struct op_msrs const * const msrs)
return;
}

+#if 0
if (cpu_has_arch_perfmon) {
union cpuid10_eax eax;
eax.full = cpuid_eax(0xa);
if (counter_width < eax.split.bit_width)
counter_width = eax.split.bit_width;
}
+#endif


this tweak did not work on later kernels, that i tested, though, and i
haven't had time to look into it in more detail.

tim
--
tim@klingt.org
http://tim.klingt.org

Linux is like a wigwam: no windows, no gates, apache inside, stable.


\
 
 \ /
  Last update: 2009-02-18 12:23    [W:0.347 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site