lkml.org 
[lkml]   [2009]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c

* Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:

> Ingo Molnar wrote:
> > We routinely mention Sparse, lockdep, Coverity, Coccinelle, kmemleak,
> > ftrace, kmemcheck and other tools as well when it motives to fix a bug
> > or uncleanliness. [...] It is absolutely fine to
> > mention checkpatch when it catches uncleanliness in code that already
> > got merged. I dont understand your point.
>
> I wrote "don't mention checkpatch" but I really meant "think about what
> the effect of the patch is and describe this".

Are you arguing that in all those other cases the tools should not be
mentioned either? I dont think that position is tenable.

Ingo


\
 
 \ /
  Last update: 2009-02-18 12:23    [W:1.116 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site