Messages in this thread | | | Date | Mon, 16 Feb 2009 16:50:23 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c |
| |
* Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> Ingo Molnar wrote: > > We routinely mention Sparse, lockdep, Coverity, Coccinelle, kmemleak, > > ftrace, kmemcheck and other tools as well when it motives to fix a bug > > or uncleanliness. [...] It is absolutely fine to > > mention checkpatch when it catches uncleanliness in code that already > > got merged. I dont understand your point. > > I wrote "don't mention checkpatch" but I really meant "think about what > the effect of the patch is and describe this".
Are you arguing that in all those other cases the tools should not be mentioned either? I dont think that position is tenable.
Ingo
| |