lkml.org 
[lkml]   [2009]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[patch 6/8] cifs: use kzfree()
Use kzfree() instead of memset() + kfree().

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Steve French <sfrench@samba.org>
---
fs/cifs/connect.c | 7 ++-----
fs/cifs/misc.c | 12 ++++--------
2 files changed, 6 insertions(+), 13 deletions(-)
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -2433,11 +2433,8 @@ mount_fail_check:
out:
/* zero out password before freeing */
if (volume_info) {
- if (volume_info->password != NULL) {
- memset(volume_info->password, 0,
- strlen(volume_info->password));
- kfree(volume_info->password);
- }
+ if (volume_info->password != NULL)
+ kzfree(volume_info->password);
kfree(volume_info->UNC);
kfree(volume_info->prepath);
kfree(volume_info);
--- a/fs/cifs/misc.c
+++ b/fs/cifs/misc.c
@@ -97,10 +97,8 @@ sesInfoFree(struct cifsSesInfo *buf_to_f
kfree(buf_to_free->serverOS);
kfree(buf_to_free->serverDomain);
kfree(buf_to_free->serverNOS);
- if (buf_to_free->password) {
- memset(buf_to_free->password, 0, strlen(buf_to_free->password));
- kfree(buf_to_free->password);
- }
+ if (buf_to_free->password)
+ kzfree(buf_to_free->password);
kfree(buf_to_free->domainName);
kfree(buf_to_free);
}
@@ -132,10 +130,8 @@ tconInfoFree(struct cifsTconInfo *buf_to
}
atomic_dec(&tconInfoAllocCount);
kfree(buf_to_free->nativeFileSystem);
- if (buf_to_free->password) {
- memset(buf_to_free->password, 0, strlen(buf_to_free->password));
- kfree(buf_to_free->password);
- }
+ if (buf_to_free->password)
+ kzfree(buf_to_free->password);
kfree(buf_to_free);
}




\
 
 \ /
  Last update: 2009-02-18 12:23    [from the cache]
©2003-2011 Jasper Spaans