Messages in this thread |  | | | Date | Sun, 15 Feb 2009 14:34:33 +0100 | | From | Jean Delvare <> | | Subject | Re: [PATCH] hwmon/hdaps: Fix bug 7154 inversion of separate axis |
| |
On Sat, 14 Feb 2009 14:25:56 -0800, Dmitry Torokhov wrote: > On Fri, Feb 13, 2009 at 01:38:01PM +0100, Frank Seidel wrote: > > -module_param_named(invert, hdaps_invert, bool, 0); > > -MODULE_PARM_DESC(invert, "invert data along each axis"); > > +module_param_named(invert, hdaps_invert, int, 0); > > +MODULE_PARM_DESC(invert, "invert data along each axis. 1 invert x-axis, " > > + "2 invert y-axis, 3 invert both axes."); > > > > Why don't you make these 0644? I don't see why they can't be changed > "on fly".
hdaps_invert can already be read and written via a sysfs attribute. We really don't need 2 ways to do it, so either the sysfs file or the module parameter should be dropped.
-- Jean Delvare
|  |