lkml.org 
[lkml]   [2009]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND/PATCH] ext[234]: Return -EIO not -ESTALE on directory traversal missing inode
    On Sat, Feb 14, 2009 at 11:53:48PM -0500, Bryan Donlan wrote:
    > > I'm dubious about unlikely() here; OTOH, penalizing the error case
    > > seems reasonable.
    >
    > I can leave it without the unlikely(), as it was before, but as far as
    > I can tell, this should never happen under a non-corrupted, non-broken
    > hardware filesystem, so it seems like a reasonable annotation to me.

    You're right. I was looking at the wrong place in the source, and
    thought this could happen if the lookup failed; but yes, you're right,
    this case can only happen if the filesystem is corrupted or there is
    an I/O error.

    - Ted


    \
     
     \ /
      Last update: 2009-02-15 06:43    [W:0.021 / U:182.740 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site