lkml.org 
[lkml]   [2009]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 20/43] drivers/net/hamradio: fix sparse warning: context imbalance
    Date
    Impact: Attribute functions with __acquires(...) resp. __releases(...).

    Fix this sparse warnings:
    drivers/net/hamradio/bpqether.c:387:13: warning: context imbalance in 'bpq_seq_start' - wrong count at exit
    drivers/net/hamradio/bpqether.c:419:13: warning: context imbalance in 'bpq_seq_stop' - unexpected unlock

    Signed-off-by: Hannes Eder <hannes@hanneseder.net>
    ---
    drivers/net/hamradio/bpqether.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c
    index 723e9c1..44b183b 100644
    --- a/drivers/net/hamradio/bpqether.c
    +++ b/drivers/net/hamradio/bpqether.c
    @@ -386,6 +386,7 @@ static int bpq_close(struct net_device *dev)
    * Proc filesystem
    */
    static void *bpq_seq_start(struct seq_file *seq, loff_t *pos)
    + __acquires(RCU)
    {
    int i = 1;
    struct bpqdev *bpqdev;
    @@ -418,6 +419,7 @@ static void *bpq_seq_next(struct seq_file *seq, void *v, loff_t *pos)
    }

    static void bpq_seq_stop(struct seq_file *seq, void *v)
    + __releases(RCU)
    {
    rcu_read_unlock();
    }


    \
     
     \ /
      Last update: 2009-02-14 22:37    [W:0.024 / U:91.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site