lkml.org 
[lkml]   [2009]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/7][RFC] powerpc64, tracing: add function graph tracer with dynamic tracing

    On Fri, 13 Feb 2009, Benjamin Herrenschmidt wrote:

    >
    > > @@ -55,8 +56,9 @@ static unsigned char *ftrace_call_replace(unsigned
    > > long ip, unsigned long addr)
    > > */
    > > addr = GET_ADDR(addr);
    > >
    > > - /* Set to "bl addr" */
    > > - op = 0x48000001 | (ftrace_calc_offset(ip, addr) & 0x03fffffc);
    > > + /* if (link) set op to 'bl' else 'b' */
    > > + op = 0x48000000 | (link ? 1 : 0);
    > > + op |= (ftrace_calc_offset(ip, addr) & 0x03fffffc);
    >
    > Any reason why you aren't using the code in
    > arch/powerpc/lib/code-patching.c here ?

    Yes, because I did not know about it ;-)

    I'll write up a patch to change this. But I'll post this series as is for
    now.

    Thanks,

    -- Steve



    \
     
     \ /
      Last update: 2009-02-13 06:25    [W:0.019 / U:1.812 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site