lkml.org 
[lkml]   [2009]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Update jhash.h with the new version of Jenkins' hash
From
Date
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> writes:

> On Wed, 11 Feb 2009, wli@movementarian.org wrote:
>
>> On Wed, Feb 11, 2009 at 11:19:20AM +0100, Jozsef Kadlecsik wrote:
>> > /* The golden ration: an arbitrary value */
>> > -#define JHASH_GOLDEN_RATIO 0x9e3779b9
>> > +#define JHASH_GOLDEN_RATIO 0xdeadbeef
>>

0xdeadbeef is a really bad choice of an arbitrary value. It is
already used in multiple places. Only a few of which are currently
listed in linux/poison.h and if I happened to see that number in a
debug trace having to sort through all of the possible sources looks
like a major pain.

I don't really care what we call it but somehow 0xdeadbeef strikes me
as wrong and something that will make debugging harder.

Eric


\
 
 \ /
  Last update: 2009-02-12 21:01    [W:0.076 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site