Messages in this thread |  | | | Date | Thu, 12 Feb 2009 17:47:21 +0100 | | From | Frederic Weisbecker <> | | Subject | Re: [PATCH 0/7][RFC] function graph tracer port to PowerPC |
| |
On Thu, Feb 12, 2009 at 11:31:44AM -0500, Steven Rostedt wrote: > > On Thu, 12 Feb 2009, Frederic Weisbecker wrote: > > > On Wed, Feb 11, 2009 at 08:10:51PM -0500, Steven Rostedt wrote: > > > > > > The following set of patches are RFC and not for inclusion > > > (unless everyone is fine with them as is). > > > > > > This is the port to PowerPC of the function graph tracer that was written > > > by Frederic Weisbecker for the x86 architecture. It is broken up > > > into a series of logical steps. > > > > > > 1) get generic code ready for other archs > > > 2) get PowerPC 64-bit working with just static function tracing > > > 3) get PowerPC 64-bit working with dynamic function tracing > > > 4) get PowerPC 32-bit working with just static function tracing > > > 5) get PowerPC 32-bit working with dynamic function tracing > > > > > > (with some clean ups in between) > > > > > > > > > Thanks a lot Steven! > > I'm sad to not having a Power Pc to test it... > > BTW, Can I count that as an Acked-by: for the first patch. Since the first > patch does modify your code. > > -- Steve >
Yes of course, I knew most of it was architecture independant but I delayed this TODO for future ports, and you've done it.
Thanks.
Just a micro detail: the ftrace_push/pop_return_trace are parts of the core of the entry/return probe, something that could be used by other users than the function graph tracer itself.
Perhaps it would be better to put them in kernel/trace/ftrace.c What do you think?
Anyway, Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
|  |