lkml.org 
[lkml]   [2009]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/16] dma-debug: add core checking functions
On Thu, Feb 05, 2009 at 09:07:59PM +0000, David Woodhouse wrote:
> On Mon, 2009-01-19 at 15:46 +0100, Joerg Roedel wrote:
> > + if (ref->type != entry->type) {
> > + err_printk(ref->dev, "DMA-API: device driver frees "
> > + "DMA memory with wrong function "
> > + "[device address=0x%016llx] [size=%llu bytes] "
> > + "[mapped as %s] [unmapped as %s]\n",
> > + ref->dev_addr, ref->size,
> > + type2name[entry->type], type2name[ref->type]);
>
> e1000e 0000:00:19.0: DMA-API: device driver frees DMA memory with wrong
> function [device address=0x00000000ffedc002] [size=90 bytes] [mapped as
> single] [unmapped as page]
>
>
> <davem> That debug check is excessive, substituting those two things
> works for every DMA API implementation I am aware of

True. Buts it is an API violation, isn't it?

Joerg



\
 
 \ /
  Last update: 2009-02-12 15:51    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site