lkml.org 
[lkml]   [2009]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] [9/9] x86: CMCI: Recheck CMCI banks after APIC has been enabled on CPU #0
Date

One the first CPU the machine checks are enabled early before
the local APIC is enabled. This could in theory lead
to some lost CMCI events very early during boot because
CMCIs cannot be delivered with disabled LAPIC.

The poller also doesn't recover from this because it doesn't
check CMCI banks.

Add an explicit CMCI banks check after the LAPIC is enabled.
This is only done for CPU #0, the other CPUs only initialize
machine checks after the LAPIC is on.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
arch/x86/kernel/apic.c | 7 +++++++
1 file changed, 7 insertions(+)
Index: linux/arch/x86/kernel/apic.c
===================================================================
--- linux.orig/arch/x86/kernel/apic.c 2009-02-12 12:03:15.000000000 +0100
+++ linux/arch/x86/kernel/apic.c 2009-02-12 12:03:15.000000000 +0100
@@ -48,6 +48,7 @@
#include <asm/apic.h>
#include <asm/i8259.h>
#include <asm/smp.h>
+#include <asm/mce.h>

#include <mach_apic.h>
#include <mach_apicdef.h>
@@ -1270,6 +1271,12 @@
apic_write(APIC_LVT1, value);

preempt_enable();
+
+#ifdef CONFIG_X86_MCE_INTEL
+ /* Recheck CMCI information after local APIC is up on CPU #0 */
+ if (smp_processor_id() == 0)
+ cmci_recheck();
+#endif
}

void __cpuinit end_local_APIC_setup(void)

\
 
 \ /
  Last update: 2009-02-12 13:57    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site